update mapboxgl control system, 0.27.0 fixes #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 hmmm tests aren't going to work on CI since we are relying on WebGL to initialize. |
|
@tmcw ready for review! |
tmcw
reviewed
Nov 18, 2016
|
|
||
| this.subscribedActions(); | ||
| if (this._map.loaded()) this.mapState() | ||
| else this._map.on('load', () => this.mapState()); | ||
|
|
||
| return el; |
There was a problem hiding this comment.
This updates .onAdd but not .onRemove - I think that'll break map.removeControl, which expects .onRemove to exist.
There was a problem hiding this comment.
@tmcw Woops, just added onRemove. Good catch!
|
@tristen I've updated the style slightly and now instructions are located underneath the controls. How do you feel about this update?
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94, which opens the door for this plugin to use gl-js
0.27.0.What changed?
mapboxglorwindow.mapboxglwithin the pluginmap.addControlfor adding the two geocoders, since we can no longer append controls to custom divs. Since this plugin relied on that, we need to not use the control system internally and just append withappendChildto the proper element for the directions UIrequireand just useimportUses both import and require #96TODO
accessTokenthrough to the geocoders. Not sure how to access it at the point of initialization like the directions API does.cc @tmcw @tristen for the review