Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request is loaded after removeRoutes() is called #285

Merged

Conversation

Hassan950
Copy link
Contributor

Currently the removeRoutes() function doesn't abort any ongoing requests which may cause the symbols to be redrawn on the map after calling removeRoutes()

This bug occurs frequentally to users with slow internet as the request may take longer time to be loaded while the removeRoutes() was already called

@aaarafat
Copy link

Currently the removeRoutes() function doesn't abort any ongoing requests which may cause the symbols to be redrawn on the map after calling removeRoutes()

This bug occurs frequentally to users with slow internet as the request may take longer time to be loaded while the removeRoutes() was already called

Needed 👍

Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Hassan950!

@stepankuzmin stepankuzmin merged commit 700e581 into mapbox:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants