Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer container if no element is passed #30

Closed
tristen opened this issue Dec 5, 2015 · 0 comments
Closed

Infer container if no element is passed #30

tristen opened this issue Dec 5, 2015 · 0 comments
Milestone
v1.0.0 release

Comments

@tristen
Copy link
Member

tristen commented Dec 5, 2015

Also, In addition to that change, a passed container option should look like this:

Current:

new mapboxgl.Directions(document.getElementById('map'));

Proposed:

new mapboxgl.Directions({
  container: 'map'
});

This follows the same convention as mapbox-gl-js
@tristen tristen modified the milestones: v0.0.0 release, v1.0.0 release Dec 5, 2015
tristen added a commit that referenced this issue Dec 6, 2015
@tristen
Follow options.container pattern in mapbox-gl-js
976af6a 
If `options.container` is not present, use map.getContainer instead.
Ref #30
@tristen tristen mentioned this issue Dec 6, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0 release
Development

No branches or pull requests
1 participant
@tristen