Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Alamofire for requests #29

Closed
tmcw opened this issue Apr 6, 2016 · 2 comments
Closed

Switch to Alamofire for requests #29

tmcw opened this issue Apr 6, 2016 · 2 comments
Assignees

Comments

@tmcw
Copy link
Contributor

tmcw commented Apr 6, 2016

It's not possible to cleanly set a user agent header with RequestKit, and there are likely other methods that we'll need down the line, so let's switch to the battle-tested Alamofire.

@tmcw tmcw self-assigned this Apr 6, 2016
tmcw added a commit that referenced this issue Apr 6, 2016
tmcw added a commit that referenced this issue Apr 7, 2016
tmcw added a commit that referenced this issue Apr 7, 2016
tmcw added a commit that referenced this issue Apr 7, 2016
tmcw added a commit that referenced this issue Apr 8, 2016
@1ec5
Copy link
Contributor

1ec5 commented Jun 6, 2016

This library was rewritten in #47 to remove RequestKit in favor of direction NSURLSession and NSHTTPURLResponse usage. There’s also a method that vends a URL you can use with any networking library you like, including Alamofire. These pieces will be unified when the three Mapbox Swift libraries are consolidated into one library. Are there any use cases left that would still require Alamofire?

@tmcw
Copy link
Contributor Author

tmcw commented Jul 12, 2016

Sounds like Alamofire isn't necessary, which is great! Less complexity > more complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants