Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mapbox::feature::value #64

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Refactor mapbox::feature::value #64

merged 1 commit into from
Sep 19, 2019

Conversation

pozdnyakov
Copy link
Contributor

  • add converting constructors
  • add bool operator
  • add uint tests

@pozdnyakov
Refactor mapbox::feature::value
fd1201a 
- add converting constructors
- add `bool` operator
- add uint tests
@pozdnyakov pozdnyakov force-pushed the mikhail_refactor_value branch from 1d9c7f9 to fd1201a Compare September 19, 2019 11:56
@pozdnyakov pozdnyakov merged commit 3245dda into master Sep 19, 2019
@pozdnyakov pozdnyakov deleted the mikhail_refactor_value branch September 19, 2019 12:11
@pozdnyakov pozdnyakov self-assigned this Sep 19, 2019
@springmeyer
Copy link
Contributor

Does this fix a particular bug or incorrect conversion?

@pozdnyakov
Copy link
Contributor Author

Newly added constructors are to avoid ambiguousness when value is constructed from an integral type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoabinader brunoabinader brunoabinader approved these changes

Assignees

@pozdnyakov pozdnyakov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pozdnyakov @springmeyer @brunoabinader