Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

more tests for attachments #245

Closed
springmeyer opened this issue Jan 24, 2013 · 4 comments
Closed

more tests for attachments #245

springmeyer opened this issue Jan 24, 2013 · 4 comments
Milestone

Comments

@springmeyer
Copy link

We appear to have only one test in test/rendering that uses attachments and it was added for #32. We should add more.

@springmeyer springmeyer mentioned this issue Jun 1, 2013
@springmeyer
Copy link
Author

/cc @yohanboniface @gravitystorm @ajashton @skorasaurus - could you all please make some time to add more tests of existing, working styles? Now that it appears we have fixes the known regressions, it is important to ensure we have better test coverage going forward to make future refactoring and optimizations easier.

To add tests of standalone mss files simply do:

  1. add a new file to test/rendering-mss/<filename>.mss
  2. run npm test
  3. the tests should automatically generate an expected result at test/rendering-mss/<filename>.xml
  4. git add test/rendering-mss/* && git commit -a -m "add more mss tests"
  5. provide a pull request

@springmeyer
Copy link
Author

a couple more added in 45fae55 /cc @tmcw

springmeyer pushed a commit that referenced this issue Jul 9, 2013
@springmeyer
Copy link
Author

ping @yohanboniface @gravitystorm @ajashton @skorasaurus - anyone up for contributing a few mss files that use attachments to help prevent regressions? (see my notes above from contributing tests).

yohanboniface added a commit to yohanboniface/carto that referenced this issue Aug 9, 2013
springmeyer pushed a commit that referenced this issue Aug 9, 2013
yohanboniface added a commit to yohanboniface/carto that referenced this issue Aug 9, 2013
tmcw added a commit that referenced this issue Aug 9, 2013
@springmeyer
Copy link
Author

thanks @yohanboniface for the tests. Everyone else, please don't forget to offer more tests when you think of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant