Remove opacity and use alpha component #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
commented
Apr 19, 2017
|
|
||
| let path = Path(coordinates: coordinates) | ||
| path.fillColor = UIColor.red.withAlphaComponent(0.5) | ||
| path.strokeColor = UIColor.green.withAlphaComponent(0.5) |
There was a problem hiding this comment.
Should be able to drop UIColor here but apparently, a type cannot be inferred with a subsequent method call.
1ec5
reviewed
Apr 19, 2017
MapboxStatic/Color.swift
Outdated
| @@ -27,6 +27,19 @@ internal extension Color { | |||
|
|
|||
| return NSString(format: "%02x%02x%02x", Int(r), Int(g), Int(b)) as String | |||
| } | |||
|
|
|||
| #if os(iOS) | |||
There was a problem hiding this comment.
This condition causes the macOS, tvOS, and watchOS builds to fail. Both NSColor and UIColor have the same getRed(_:green:blue:alpha:) method, so conditionalizing this code on iOS should be unnecessary.
There was a problem hiding this comment.
macOS has its own alphaComponent so !os(macOS) should do the trick.
1ec5
approved these changes
Apr 19, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
Added an internal var on UIColor that matches NSColor.alphaComponent
@1ec5 👀