Don’t even try to deserialize non-JSON response data #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with mapbox/mapbox-directions-swift#72 and mapbox/MapboxGeocoder.swift#71, don’t attempt to deserialize non-JSON response data. In the case of this library, the error would’ve been caught by the expected fallback of initializing an image out of the data. But it’s quite bizarre for the “good” code path to be inside an error handler. So now this library is additionally capable of tripping an assertion if the response claims to be JSON but isn’t well-formed for some reason.
/cc @willwhite