Update for Swift 3 #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ports the Swift 2.2 implementation to Swift 3.
| case Medium | ||
| /// Large. | ||
| case Large | ||
| /// small. |
There was a problem hiding this comment.
Nit: keep the documentation in sentence case.
| request.setValue(userAgent, forHTTPHeaderField: "User-Agent") | ||
| let task = NSURLSession.sharedSession().dataTaskWithRequest(request) { (data, response, error) in | ||
| let task = URLSession.shared().dataTask(with: request as URLRequest) { (data, response, error) in |
There was a problem hiding this comment.
Make request a var URLRequest so this cast is unnecessary.
|
|
Superseded by #41. |
|
The saga continues in #50. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the Swift 2.2 implementation to Swift 3. It is a work in progress and there are several known issues but it is functional and can be used, for now, to help test applications written with the Xcode 8 and Swift 3 betas that use MapboxStatic.
Todo:
#if swift(>=3.0)blocks to help maintain backwards compatibility with Swift 2.2+Known issues:
allowedCharacterSetin Overlay.swift seems to cause an exception in thefirst Xcode 8 beta. This needs more investigation. For now, the workaround is to use an inverted
CharacterSetforMBCustomMarkerandCharacterSet.urlPathAllowedforGeoJSONandPathoverlays.