Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift Package Manager as development environment #109

Merged
merged 8 commits into from
Nov 10, 2020
Merged

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Nov 9, 2020

Upgraded to Xcode 12, Swift 5.3, OHHTTPStubs v9.0, and Polyline v5.0. You can now open Package.swift and use a development environment managed by Swift Package Manager instead of an Xcode project with Carthage-built dependencies.

Increased the minimum deployment targets to iOS 10.0, macOS 10.12.0, tvOS 10.0, and watchOS 3.0 for compatibility with Polyline v5.0.

Avoid a compiler error when building the library on unrecognized operating system, such as Windows.

Fixes #108 and fixes #109.

/cc @captainbarbosa @frederoni

1ec5 added 3 commits November 9, 2020 13:13
Also updated conditional imports to remove assumptions about which operating systems exist.
@1ec5
Copy link
Contributor Author

1ec5 commented Nov 10, 2020

swift test is failing due to either a bug to be fixed by swiftlang/swift-package-manager#2817 or a bug reported as SR-13560:

Test Case '-[MapboxStaticTests.ClassicOverlayTests testBuiltinMarker]' started.
Fatal error: could not load resource bundle: /Applications/Xcode-12.GM.seed.app/Contents/Developer/usr/bin/MapboxStatic_MapboxStaticTests.bundle: file MapboxStaticTests/resource_bundle_accessor.swift, line 7

Edit: It was swiftlang/swift-package-manager#2817; upgrading to Xcode 12.2 fixed the issue.

@1ec5 1ec5 merged commit a1e1e1b into main Nov 10, 2020
@1ec5 1ec5 deleted the 1ec5-spm-os branch November 10, 2020 15:27
@1ec5 1ec5 linked an issue Nov 10, 2020 that may be closed by this pull request
@1ec5 1ec5 mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid compiler error when built on unrecognized operating system Upgrade to Polyline v5.0
2 participants