-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix batch geocoding request handling #148
Merged
Merged
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ecde0a1
Allowing batch geocoding of at least one query
captainbarbosa 3ef3160
Refactor mode override
captainbarbosa 265370d
Handle multiple geocoding queries
captainbarbosa bb21f69
Add clarifying comments
captainbarbosa 4d82f65
Minor feedback edits
captainbarbosa 202c3da
Set up single forward batch test case
captainbarbosa 8723c07
Add test for valid fwd batch geocoding with multiple queries
captainbarbosa 7a433ff
Add test for failed single forward batch geocode
captainbarbosa ec597f1
Add test for failed multiple forward batch geocode
captainbarbosa 3c4ba37
Add debug notes
captainbarbosa d475a79
Add no-results returned forward batch geocoding tests
captainbarbosa 9fbb49a
Rename/cleanup tests & comments
captainbarbosa ddda4f5
Switch from guard to if/let
captainbarbosa e7185e4
Add reverse batch geocode tests
captainbarbosa 6b83082
Match precision for path-matching tests
captainbarbosa 08b2f25
Fix test fixture file paths
captainbarbosa f7ef9ba
🔮
captainbarbosa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is located in the Trash on your Mac, which Bitrise has no access to.