Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add random spawn type for env_headcrabcanister #292

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Add random spawn type for env_headcrabcanister #292

merged 3 commits into from
Jan 10, 2025

Conversation

arbabf
Copy link
Collaborator

@arbabf arbabf commented Apr 12, 2024 •
edited
Loading

This PR adds a "Random" spawn type to env_headcrabcanister, for those who have needed to spawn multiple species of headcrabs.

The FGD entry is attached.
fgd_new.txt

Does this PR close any issues?

  • None

PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

1upD
1upD previously requested changes Apr 12, 2024
View reviewed changes
Copy link

@1upD 1upD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about using -1 or some arbitrarily large number instead of 3 for the index. Other than that, this looks good

sp/src/game/server/hl2/env_headcrabcanister.cpp Outdated Show resolved Hide resolved
@arbabf
Copy link
Collaborator Author

arbabf commented Apr 13, 2024

I left a comment about using -1 or some arbitrarily large number instead of 3 for the index. Other than that, this looks good

I've made the changes and updated the FGD entry to match

@Blixibon Blixibon dismissed 1upD’s stale review January 10, 2025 14:09

Requested changes have been addressed

@Blixibon Blixibon merged commit 7220a6d into mapbase-source:develop Jan 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blixibon Blixibon Blixibon approved these changes

@1upD 1upD 1upD left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arbabf @1upD @Blixibon