Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting the provided password when creating an account when no SMTP server is configured. #3401

Conversation

fhp
Copy link
Contributor

@fhp fhp commented Jan 14, 2025

Checklist

🚨 Please review the guidelines for contributing to this repository. 🚨

  • Make sure you are making a pull request against our main branch (left side)
  • Check that that your branch is up to date with our main.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Check that the tests and code linter both pass.
  • If you're a new contributor, please sign our contributor license agreement.

Warnings

  • This PR will change existing database contents.
  • This PR introduces a breaking change to existing installations.

Summary

When creating a new account via the /settings/users/new page, while Email delivery is not configured, the entered password is not stored into the database. It is instead replaced by a randomly generated password.

Linked issues

I did not find an existing issue.

Description of changes

I added password and password_confirmation to the list of user params that were allowed. I also update the keys from key to string, so they matched with what was provided and would be overwritten by the keys in the user_params hash.

@Floppy Floppy enabled auto-merge January 14, 2025 22:41
@Floppy Floppy added the bug Something isn't working label Jan 14, 2025
auto-merge was automatically disabled January 15, 2025 08:35

Head branch was pushed to by a user without write access

@fhp fhp force-pushed the fix-password-on-account-creation-without-smtp-configured branch from 8d14b15 to ba83c4b Compare January 15, 2025 08:35
@Floppy Floppy enabled auto-merge January 15, 2025 14:19
@Floppy Floppy merged commit 3922e6a into manyfold3d:main Jan 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants