Fix setting the provided password when creating an account when no SMTP server is configured. #3401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
🚨 Please review the guidelines for contributing to this repository. 🚨
Warnings
Summary
When creating a new account via the
/settings/users/new
page, while Email delivery is not configured, the entered password is not stored into the database. It is instead replaced by a randomly generated password.Linked issues
I did not find an existing issue.
Description of changes
I added
password
andpassword_confirmation
to the list of user params that were allowed. I also update the keys from key to string, so they matched with what was provided and would be overwritten by the keys in theuser_params
hash.