Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smtp config: add port number and disable ssl certificate validation #3400

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

fhp
Copy link
Contributor

@fhp fhp commented Jan 14, 2025

Checklist

🚨 Please review the guidelines for contributing to this repository. 🚨

  • Make sure you are making a pull request against our main branch (left side)
  • Check that that your branch is up to date with our main.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Check that the tests and code linter both pass.
  • If you're a new contributor, please sign our contributor license agreement.

Warnings

  • This PR will change existing database contents.
  • This PR introduces a breaking change to existing installations.

Summary

This PR adds two config options for the SMTP server. I needed to configure the SMTP port, and I found another issue that needed the SSL verification disabled.

Linked issues

resolves #2380

Description of changes

I added two config setting:

  • SMTP_PORT can be used to set the port for the smtp server. It configures the config.action_mailer.smtp_settings.port field if set.
  • SMTP_VERIFY_SSL_MODE can be set to none to disable the checks of the ssl certificate of the SMTP server. It configures the config.action_mailer.smtp_settings.openssl_verify_mode field if set.

@Floppy
Copy link
Collaborator

Floppy commented Jan 14, 2025

Thanks very much!

@Floppy Floppy enabled auto-merge January 14, 2025 22:23
@Floppy Floppy merged commit aa3c834 into manyfold3d:main Jan 14, 2025
10 checks passed
@Floppy Floppy added the feature User-facing features and product enhancements label Jan 14, 2025
@Floppy
Copy link
Collaborator

Floppy commented Jan 15, 2025

@fhp I'm going to change the name of SMTP_VERIFY_SSL_MODE to SMTP_OPENSSL_VERIFY_MODE if you don't mind, for consistency. I'm adding the rest of the settings too in order to help fix #3391.

@fhp
Copy link
Contributor Author

fhp commented Jan 17, 2025

I don't mind, I just added it because there was an open issue for it.

@Floppy
Copy link
Collaborator

Floppy commented Jan 17, 2025

@fhp and it's much appreciated! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature User-facing features and product enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants