Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message on home page with no activity #3375

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

mtancoigne
Copy link
Contributor

@mtancoigne mtancoigne commented Jan 9, 2025

Checklist

🚨 Please review the guidelines for contributing to this repository. 🚨

  • Make sure you are making a pull request against our main branch (left side)
  • Check that that your branch is up to date with our main.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Check that the tests and code linter both pass.
  • If you're a new contributor, please sign our contributor license agreement.

Warnings

  • This PR will change existing database contents.
  • This PR introduces a breaking change to existing installations.

Summary

Display a message when there are no activities to display on the home page

Linked issues

Resolves #2743

Description of changes

  • Moves conditions from the activity/* partials to Timeline.local method,
  • Display a message on home page when feed list is empty.

Translations for fr/en are included

image

@mtancoigne mtancoigne marked this pull request as ready for review January 9, 2025 11:11
@mtancoigne
Copy link
Contributor Author

I'll fix the linting issue in the ERB (I forgot to run it locally 🙃 )

@mtancoigne mtancoigne force-pushed the manu/home-activities-message branch from 685b6f2 to 37b26bc Compare January 9, 2025 12:17
@Floppy Floppy merged commit 81edee1 into manyfold3d:main Jan 9, 2025
11 checks passed
@Floppy Floppy added the feature User-facing features and product enhancements label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature User-facing features and product enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login Page / Login Prompt
2 participants