Merge pull request #3306 from manyfold3d/handle-invalid-domains

Handle invalid domains safely in Link#site

app/models/link.rb

@@ -6,7 +6,9 @@ def host
   end
 
   def site
-    PublicSuffix.parse(host).sld.to_sym
+    PublicSuffix.parse(host).sld
+  rescue PublicSuffix::DomainInvalid
+    host
   end
 
   def self.ransackable_attributes(_auth_object = nil)

spec/models/link_spec.rb

@@ -0,0 +1,12 @@
+require "rails_helper"
+RSpec.describe Link do
+  it "extracts site name from domain" do
+    link = described_class.new(url: "https://www.example.com")
+    expect(link.site).to eq "example"
+  end
+
+  it "extracts site fails safe with bad domain" do
+    link = described_class.new(url: "https://boop")
+    expect(link.site).to eq "boop"
+  end
+end