KR921 Frequency Plan #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution. As this library is based on MCCI's Arduino LMIC library, I'd prefer if the Korean frequency plan was part of their library. Otherwise it will be difficult to keep up with the bug fixes and enhancement in that library. Can you also create a pull request for mcci-catena/arduino-lmic? |
|
Sure I'll take a look and see if they're interested. |
|
I'm the maintainer of https://github.com/mcci-catena/arduino-lmic; would be happy to have a pull request. |
|
The dev branch now contains the latest version of the MCCI-Catena LMIC library that includes the frequency plan for South Korea. So if you don't mind, I'm going to close this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I have so far in trying to match with the following frequency plan for TTN:
https://account.thethingsnetwork.org/api/v2/frequency-plans/KR_920_923
Not sure what copyright notices should be applied to the "new" files based on "existing" files.
For many of the "magic numbers", made my best guess.
Looks like KR921 doesn't have FSK, so I took that out.
https://www.thethingsnetwork.org/docs/lorawan/frequency-plans.html#kr920-923
Verified operation of LoRa Node -> LoRa Gateway with Join/Uplink/Downlink operation on TTN with Gateway using KR_920_923 as stated above.