Add Send to trait objects returned from APIs, for interoperability with async code
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Looking good. A potential drawback I see is the following: VFS implementations would now be required to return |
open_file/create_file/append_file Previously, these APIs would return a trait object not marked Send, which made it difficult to use in an async context. Adding 'Send' requires very little modification and greatly improves usability for async code.
Property404
force-pushed
the
Property404/open-as-send
branch
from
969da81
to
28e96fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these APIs would return a trait object not marked Send, which made it difficult to use in an async context.
Adding 'Send' requires very little modification (though I think this should still be a major version bump because it affects a public trait) and greatly improves usability for async code.