Use require to retrieve the app's config
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
commented
Jun 16, 2022
The extra addon config test case added an extra value to the application template which breaks the FastBoot test
This uses loader.js's `require` function to retrieve the app's environment config. This bypasses the `importSync` dependency checking that happens in Embroider builds which causes the build to fail since the dependency doesn't exist in the addon.
This was referenced Jun 28, 2022
|
I'm seeing a build warning:
Which looks to be caused by this change. |
|
Made #49 to resolve the warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses loader.js's
requirefunction to retrieve the app's environment config. This bypasses theimportSyncdependency checking that happens in Embroider builds which causes the build to fail since the dependency doesn't exist in the addon.I included the commits of #42, #43 and #44 so that I could test it still works under all those new tests. I'll rebase after those are merged.