Use ternary instead of if statement in module export #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josemarluedke Could you cross-post this issue to the Embroider repo? Sounds like there might be an underlying issue that we would want to look into over there as well? |
|
Hey thanks for your contribution @josemarluedke 🎉 As it turns out I got nerd sniped while pairing with @pichfl and we fixed this problem, along with the issue with duplication of configs 💪 You can take a look here #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue we are seeing when building apps in production mode. This issue was introduced in version 1.0.3 with PR #35.
Before this change, when building in production mode, we would not get the config from the app:
Now with this change, we get the config in production and all other modes:
Paired with @eugenioenko.