Skip to content

Commit

Permalink
Merge pull request #49 from bertdeblock/resolve-missing-addon-warning
Browse files Browse the repository at this point in the history
  • Loading branch information
mansona authored Jun 29, 2022
2 parents 765af56 + d6de81b commit 1bee9ca
Show file tree
Hide file tree
Showing 11 changed files with 30 additions and 32 deletions.
1 change: 0 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ module.exports = {
'./testem.js',
'./blueprints/*/index.js',
'./config/**/*.js',
'./lib/**/*.js',
'./tests/dummy/config/**/*.js',
],
parserOptions: {
Expand Down
1 change: 0 additions & 1 deletion .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
/CONTRIBUTING.md
/ember-cli-build.js
/testem.js
/lib/baz/
/tests/
/yarn-error.log
/yarn.lock
Expand Down
7 changes: 0 additions & 7 deletions lib/baz/config/environment.js

This file was deleted.

9 changes: 0 additions & 9 deletions lib/baz/index.js

This file was deleted.

6 changes: 0 additions & 6 deletions lib/baz/package.json

This file was deleted.

24 changes: 24 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^2.3.0",
"ember-cli": "~3.28.2",
"ember-cli-app-version": "^5.0.0",
"ember-cli-dependency-checker": "^3.2.0",
"ember-cli-fastboot": "^3.3.0",
"ember-cli-fastboot-testing": "^0.6.0",
Expand Down Expand Up @@ -79,9 +80,6 @@
"edition": "octane"
},
"ember-addon": {
"configPath": "tests/dummy/config",
"paths": [
"lib/baz"
]
"configPath": "tests/dummy/config"
}
}
2 changes: 1 addition & 1 deletion tests/acceptance/ember-get-config-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ module('Acceptance | ember get config', function (hooks) {
test('it includes config from addons', async function (assert) {
await visit('/');

assert.dom('#baz').hasText('qux');
assert.dom('#app-name').hasText('ember-get-config');
});
});
2 changes: 1 addition & 1 deletion tests/dummy/app/controllers/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ import Controller from '@ember/controller';
import config from 'ember-get-config';

export default Controller.extend({
baz: config.baz,
appName: config.APP.name,
foo: config.foo,
});
2 changes: 1 addition & 1 deletion tests/dummy/app/templates/application.hbs
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<div id="baz">{{this.baz}}</div>
<div id="app-name">{{this.appName}}</div>
<div id="foo">{{this.foo}}</div>
2 changes: 1 addition & 1 deletion tests/fastboot/basic-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ module('FastBoot | basic', function (hooks) {
test('it renders a page...', async function (assert) {
let { htmlDocument } = await visit('/');

assert.dom('body', htmlDocument).hasText('qux bar');
assert.dom('body', htmlDocument).hasText('ember-get-config bar');
});
});

0 comments on commit 1bee9ca

Please sign in to comment.