Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 88: hold off on DESTROY decoration and Strategies #260

Merged
merged 11 commits into from
Jul 31, 2020

Conversation

kmanning
Copy link
Collaborator

@kmanning kmanning commented Jul 30, 2020

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #260 into master will increase coverage by 6.12%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   60.70%   66.82%   +6.12%     
==========================================
  Files          37       35       -2     
  Lines         855      835      -20     
  Branches      216      218       +2     
==========================================
+ Hits          519      558      +39     
+ Misses        239      177      -62     
- Partials       97      100       +3     
Impacted Files Coverage Δ
src/AnsiColorPlugin.groovy 25.00% <ø> (+5.00%) ⬆️
src/ConditionalApplyPlugin.groovy 64.28% <ø> (-2.39%) ⬇️
src/CrqPlugin.groovy 35.89% <ø> (+0.89%) ⬆️
src/Jenkinsfile.groovy 25.00% <0.00%> (+1.36%) ⬆️
src/DestroyPlugin.groovy 92.85% <90.00%> (+17.85%) ⬆️
src/TerraformEnvironmentStage.groovy 91.42% <100.00%> (+13.16%) ⬆️
src/TerraformApplyCommand.groovy 92.10% <0.00%> (+5.26%) ⬆️
src/ConfirmApplyPlugin.groovy 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baeaea4...024b9f5. Read the comment docs.

@kmanning kmanning requested a review from jleopold28 July 30, 2020 21:03
@kmanning kmanning added this to the v5.9 milestone Jul 30, 2020
@kmanning kmanning merged commit 9bac14b into manheim:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants