Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compatibility] Treat KIND values case-insensitive #140

Closed
rfc2822 opened this issue Aug 18, 2023 · 2 comments · Fixed by #141
Closed

[Compatibility] Treat KIND values case-insensitive #140

rfc2822 opened this issue Aug 18, 2023 · 2 comments · Fixed by #141

Comments

@rfc2822
Copy link
Contributor

rfc2822 commented Aug 18, 2023 •
edited
Loading

There are clients/servers which set KIND:GROUP instead of KIND:group although RFC 6350 specifies "group" (lower-case) and values are case-sensitive.

For better compatibility, I suggest to make the equals() calls in Kind.is… case-insensitive:

ez-vcard/src/main/java/ezvcard/property/Kind.java

Lines 114 to 116 in b8f0a18

public boolean isGroup() {
return GROUP.equals(value);
}

@ArnyminerZ ArnyminerZ mentioned this issue Aug 21, 2023
Merged
mangstadt pushed a commit that referenced this issue Aug 23, 2023
@ArnyminerZ
Ignored case on KIND GROUP (#141)
acbeb66 
Use case-insensitive comparison for KIND

#140
mangstadt added a commit that referenced this issue Aug 23, 2023
@mangstadt
Use case-insensitive comparison for KIND
c2bc93f 
#140
@mangstadt
Copy link
Owner

Fixed in acbeb66.

@mangstadt
Copy link
Owner

ez-vcard version 0.12.1 has been released, which includes this bug fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignored case on KIND GROUP ArnyminerZ/ez-vcard
2 participants
@rfc2822 @mangstadt