Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMPP: case-insensitive comparison of schemes #123

Closed
rfc2822 opened this issue Mar 8, 2022 · 1 comment
Closed

IMPP: case-insensitive comparison of schemes #123

rfc2822 opened this issue Mar 8, 2022 · 1 comment

Comments

@rfc2822
Copy link
Contributor

rfc2822 commented Mar 8, 2022

I suggest to perform case-insensitive comparision of schemes in Impp.isProtocol, so that not only IMPP:icq:123456 would be recognized by isProtocol("icq") and isIcq() but also IMPP:ICQ:123456.
mangstadt added a commit that referenced this issue May 14, 2022
@mangstadt
IMPP URI scheme comparison should be case-insensitive
8736e48 
#123
@mangstadt
Copy link
Owner

mangstadt commented May 14, 2022 •
edited
Loading

Thanks for catching that. Don't know what I was thinking. facepalm

8736e48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rfc2822 @mangstadt