Correct implementation of rfc7636 section 4.1 #629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across an issue with the
code_verifier
parameter when requesting a token using the Code flow and PKCE using Ory Hydra (#628). After a discussion with @jeroenheijmans and reading the spec he pointed me to https://tools.ietf.org/html/rfc7636#section-4.1 it looks as though thecreateNonce
function was implemented slightly incorrectly. This leads to an incorrectly base64url encoded string being generated which the Go standard library being used in Ory Hydra would not parse. This PR changes the generation to follow the spec more closely:I have tested this both with Ory Hydra and IndentityServer4.