Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken default config.xml #640

Closed
tGecko opened this issue Jan 17, 2025 · 14 comments · Fixed by #641
Closed

Broken default config.xml #640

tGecko opened this issue Jan 17, 2025 · 14 comments · Fixed by #641
Labels
🐛 bug Something isn't working

Comments

@tGecko
Copy link
Contributor

tGecko commented Jan 17, 2025

What's the problem?

PR #638 added a comment to the default config.xml which seems to be interfering with the install script.
With it, the install will fail completely, early in the setup process.

Steps to Reproduce

  1. Follow install instructions
  2. Observe that install.ps1 fails with this error:

Image

Environment

VMware Workstation
10.0.19045
5.1.19041.5369
2.4.1
Boxstarter|3.0.3

Additional Information

No response

@tGecko tGecko added the 🐛 bug Something isn't working label Jan 17, 2025
@JackStuart
Copy link

JackStuart commented Jan 18, 2025

Image

This seems to be because the addlicense tool isn't supporting zero-width no-break space characters. I'm working on a fix now but it doesn't look like anyone from Google is actively looking at that because it's been 2.5 years without a commit..

Edit: PR Here - google/addlicense#166

@awaboo3
Copy link

awaboo3 commented Jan 18, 2025

i still have the same error that @tGecko have.

@Not-Bruno
Copy link

Have the same Issue on Win11 and Win10 VM

@Jay1508
Copy link

Jay1508 commented Jan 18, 2025

I have the same issue despite trying the version before (from september 2024). Can we please get an update on when it will get fixed?

@tGecko
Copy link
Contributor Author

tGecko commented Jan 18, 2025

Here's a workaround for those who want to install Flare right now:

  • Download the config.xml from my PR here and save it as config.xml
  • Start install.ps1 with the parameter -customConfig c:\path\to\config.xml

@knotimpressed
Copy link

Here's a workaround for those who want to install Flare right now:

  • Download the config.xml from my PR here and save it as config.xml
  • Start install.ps1 with the parameter -customConfig c:\path\to\config.xml

Had the same issue and this worked for me, thank you so much.

@sasha-taruberesc
Copy link

Here's a workaround for those who want to install Flare right now:

  • Download the config.xml from my PR here and save it as config.xml
  • Start install.ps1 with the parameter -customConfig c:\path\to\config.xml

Had the same issue and this worked for me, thank you so much.

Hi, I tried this today to fix the same issue and I still have the same error message. This solution did not work for me. Where do we save the config.xml we download from the PR? I copied and pasted that into notes and saved it on the desktop of the Windows 10 VM where I am trying to install FlareVM. Please may I receive assistance with this? I have no idea what I am doing wrong.

@JackStuart
Copy link

@sasha-taruberesc - To confirm you are using the correct XML. What is in the first line?

Can you try

[xml](Get-Content .\config.xml)

@sasha-taruberesc
Copy link

sasha-taruberesc commented Jan 20, 2025

@sasha-taruberesc - To confirm you are using the correct XML. What is in the first line?

Can you try

[xml](Get-Content .\config.xml)

I just downloaded the file from the previous PR from the two mentioned above in this thread from either knotimpressed or tGecko. I am not sure what the XML is...

Where do I type [xml]Get-Content.\config.xml}?

@JackStuart
Copy link

tGecko's XML file is in the correct format and works. If you get the same error as mentioned in the OP then you aren't using the right XML file

@sasha-taruberesc
Copy link

tGecko's XML file is in the correct format and works. If you get the same error as mentioned in the OP then you aren't using the right XML file

Okay, I see. How do I fix this? I downloaded tGecko's PR and pasted that code in notes and saved it as config.xml on the desktop of the Windows 10 virtual machine.

@JackStuart
Copy link

Did you try reading what tGecko said?

#640 (comment)

@sasha-taruberesc
Copy link

Did you try reading what tGecko said?

#640 (comment)

Yes, I have read all the solutions and that is why I am seeking help here to fix the problem I am still having. I tried what the thread told me to do. I am trying to find out why the solution they posted is not working for me.

@Ana06 Ana06 changed the title Since PR #638 Flare VM will not install using the default config.xml Broken default config.xml Jan 20, 2025
Ana06 added a commit that referenced this issue Jan 20, 2025
Fix for Issue #640 - config.xml misformatted
@Ana06
Copy link
Member

Ana06 commented Jan 20, 2025

I broke the config file in #638 (breaking FLARE-VM) when I added license & copyright headers using addlicense 🙈 The config file has a <feff> (Byte Order Mark (BOM)) that shouldn't be there and caused the header was added in the wrong way. The issue is now fixed. Please delete the config.xml file in the Desktop and re-run the FLARE-VM installation. Thanks @tGecko and everyone that commented here to help fixing the issue! 💐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants