Lint rule formatting and improved rule dump #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # only do this for the features section, so the meta description doesn't get reformatted | ||
| # assumes features section always exists | ||
| features_offset = doc.find("features") | ||
| doc = doc[:features_offset] + doc[features_offset:].replace(" description:", " description:") |
This was referenced Jan 27, 2021
mr-tz
commented
Jan 27, 2021
scripts/lint.py
Outdated
Comment on lines
300
to
304
| # fix negative numbers | ||
| # - offset: -0x30 | ||
| # instead of | ||
| # - offset: !!int '0x-30' | ||
| expected = re.sub(r"!!int '0x-([0-9a-fA-F]+)'", r"-0x\1", expected) |
mr-tz
changed the title
williballenthin
approved these changes
Jan 28, 2021
|
Thanks, I'll reformat the new rules resulting in the linter fail now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in mandiant/capa-rules#230 have been performed using the updated
capafmtscript included here.closes #313