Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule set does not correctly validate dependencies across scopes #2124

Open
williballenthin opened this issue Jun 6, 2024 · 2 comments
Open
Labels
bug Something isn't working
Milestone

Comments

@williballenthin
Copy link
Collaborator

capa-rules contains at least one rule with an impossible dependency, and capa nor its linter complains. We should ensure that capa correct tracks dependencies across scopes, or warns the user when its impossible.

log keystrokes via application hook is a dynamic: call scoped rule that relies on set application hook, which is a dynamic: thread scoped rule. Since we evaluate from small to large scopes (call before thread), this dependency will never be satisfied.

@williballenthin williballenthin added the bug Something isn't working label Jun 6, 2024
@williballenthin
Copy link
Collaborator Author

also allocate memory > link function at runtime on Windows

@mr-tz
Copy link
Collaborator

mr-tz commented Sep 17, 2024

@williballenthin is it fine if we punt this again to the next release or should we address it now for v7.3.0?

@mr-tz mr-tz modified the milestones: v7.3, v7.4 Sep 17, 2024
@mr-tz mr-tz modified the milestones: v7.4, v7.5 Oct 2, 2024
@mr-tz mr-tz modified the milestones: v8.0, v8.x Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants