-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update and add rules #726
update and add rules #726
Conversation
- string: /netmon\.exe/i | ||
- string: /WPE PRO\.exe/i | ||
- string: /decompile\.exe/i | ||
- string: /ollydbg(\.exe)?/i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\.exe
-> (\.exe)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't look too risky (for bad performance) since the prefix must match before the optional is evaluated.
- api: System.Runtime.InteropServices.Marshal::ReadInt32 | ||
- number: 0x3C = IMAGE_DOS_HEADER.e_lfanew | ||
- api: System.Runtime.InteropServices.Marshal::ReadInt32 | ||
- number: 0x6 = IMAGE_NT_HEADERS.FileHeader.NumberOfSections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this too general? unfortunately, I did not see additional good features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is System.Runtime.InteropServices.Marshal::ReadInt32
this duplicated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i dont have a good sense for the prevalence of these features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe @mike-hunhoff can chime in
closes #595