Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update and add rules #726

Merged
merged 2 commits into from
Mar 23, 2023
Merged

update and add rules #726

merged 2 commits into from
Mar 23, 2023

Conversation

mr-tz
Copy link
Collaborator

@mr-tz mr-tz commented Mar 17, 2023

closes #595

- string: /netmon\.exe/i
- string: /WPE PRO\.exe/i
- string: /decompile\.exe/i
- string: /ollydbg(\.exe)?/i
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\.exe -> (\.exe)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look too risky (for bad performance) since the prefix must match before the optional is evaluated.

Comment on lines 17 to 20
- api: System.Runtime.InteropServices.Marshal::ReadInt32
- number: 0x3C = IMAGE_DOS_HEADER.e_lfanew
- api: System.Runtime.InteropServices.Marshal::ReadInt32
- number: 0x6 = IMAGE_NT_HEADERS.FileHeader.NumberOfSections
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this too general? unfortunately, I did not see additional good features

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is System.Runtime.InteropServices.Marshal::ReadInt32 this duplicated?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i dont have a good sense for the prevalence of these features.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe @mike-hunhoff can chime in

@mr-tz mr-tz requested a review from mike-hunhoff March 17, 2023 10:09
@mr-tz mr-tz merged commit 9f8863d into master Mar 23, 2023
@mr-tz mr-tz deleted the rules52-11 branch March 23, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check Anti-DebugNET coverage
2 participants