Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PlugX rule proposed in #469 #515

Merged
merged 9 commits into from
Dec 20, 2021
Merged

Conversation

Still34
Copy link
Contributor

@Still34 Still34 commented Dec 13, 2021

Summary

This PR adds the first malware-specific capa rule as initially proposed in issue #469. Specifically, this PR adds the known module watermarks found in various builds of PlugX.

Signed-off-by: Still Hsu <[email protected]>
@Still34
Copy link
Contributor Author

Still34 commented Dec 13, 2021

Per the linter, guess upstream needs to be updated to support the maec meta field.

Copy link
Collaborator

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me, thanks!

only one suggestion to tweak the directory path for family rules. let's use "malware-family" instead of "malware". with that change, i'll be happy to merge.

Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost good to go, sorry for the annoyance with the little fixes

Signed-off-by: Still Hsu <[email protected]>
@Still34
Copy link
Contributor Author

Still34 commented Dec 16, 2021

No problem. Hope the changes above are good now!

- Some samples may attempt to scrub the timestamp by replacing it with an invalid date (e.g., 0x8888888)

Signed-off-by: Still Hsu <[email protected]>
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final formatting issues (hopefully)

@Still34 Still34 requested a review from mr-tz December 20, 2021 12:22
@mr-tz
Copy link
Collaborator

mr-tz commented Dec 20, 2021

awesome, thank you very much!

@mr-tz mr-tz merged commit e2dbb34 into mandiant:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants