ci: Update CHANGELOG automatically #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2021
Ana06
commented
May 7, 2021
| - name: Add new rules to CHANGELOG | ||
| run: | | ||
| for added_file in ${{ steps.files.outputs.added }}; do | ||
| author=$(grep 'author:' rules/$added_file | sed 's/^.*: //' | sed 's/"//g' ) |
There was a problem hiding this comment.
This is just adding whatever the rule author wrote in the author field. Till now we have always used the GitHub username for the CHANGELOG. I don't know an easy way to get the GitHub username (if someone know let me know!). But I think this is ok, we just show what people prefer that we show. We could document that GitHub user is preferred.
mr-tz
approved these changes
May 7, 2021
Update new rules in capa repository's CHANGELOG with a GitHub Action automatically with every push (for example merge of PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update new rules in capa repository's CHANGELOG with a GitHub Action automatically with every push (for example merge of PR).
You can see how the created commit looks like here: Ana06/capa@7d7def3
And the action running here: https://github.com/Ana06/capa-rules/runs/2528333012?check_suite_focus=true
Needs mandiant/capa#549 to be merged to work.
Related: mandiant/capa#457.