Fix calendar sync failing on months having 1st day as Monday #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somebody created bug in the past #26. It missed steps to reproduce or a fix.
This PR describes how to reproduce and has code fix.
The issue is that calendar sync will fail on months that have Monday as 1st day of the month (e.g. 2024 April 1 is Monday).
Buggy code is:
According to the docs:
So in this code variable
first_day
can return0
(for Monday) and this will crashdatetime()
.Before the fix
After the fix