(feature) Implement creating user accounts and sessions, protecting endpoints #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cashweaver-zz
approved these changes
Oct 25, 2016
rhinodavid
added a commit
that referenced
this pull request
Nov 1, 2016
* Add team names to README * Add style guide * Add Contributing guidelines * Update CONTRIBUTING.md * (doc) Add contrib, roadmap, and reqs to README (#19) * Add contrib, roadmap, and reqs to README * Fix link to Roadmap * Add Bill, Item, and User tables * Refine schema * (feat) Add React Homepage and Billpage * Add api routes (#23) * Start express (#25) * Add api router' ; ' * Create server file * (feat) Rough out server structure * Database work to complete bill creation (#27) * Create server file * Add hashids and supertest * Ignore databases * Create controllers for database models * Implement short ids and create join table for debtors * Implement api handler specs * Implement save bill * Update README * Implement delete and edit bill input form items (#26) * Implement ability to delete billItems * Implement ability to change bill Item values * Refactor file structure and functional components * Add tip and tax fields to Bills * Add tests for Tip and Tax fields * Add tests for BillItem, BillItemList, and Bill * (refactor) Style guide updates (#29) * Add auth route' ; ' ' * (refactor) Align with style guide * (feature) Implement creating user accounts and sessions, protecting endpoints (#33) * Fix merge conflicts * Add bcrypt and session config * Add packages * Add local strategy * Implement user controller * Add placeholder response * Implement authentication routes * Fix conflicts * Fix conflicts * Add tip calculation buttons * Add createBill method * Add DescriptionField * Pass tests * (doc) JSDoc for all components * (test) Pass tests * Modify db path to stay in server folder * Add start script * Remove unwanted comma * Fix wrong require * Correct client files path * Login/signup form with proper api endpoints (#37) * Implement ability to delete billItems * Implement ability to change bill Item values * Create Login page and css file * Create route and home-link to login page * Create utils directory for helper functions * Complete login signup form with api calls * Update login api calls and variable names * Fix emailAddressChange method (#40) * Implement ability to delete billItems * Implement ability to change bill Item values * Create Login page and css file * Create route and home-link to login page * Create utils directory for helper functions * Complete login signup form with api calls * Update login api calls and variable names * Fix emailAddress change bug * Add CORS and nodemon * Merge stash * (feat) Build serverUrl based on NODE_ENV * (feature) Add API documentation (#43) * Add documentation * (feature) Add API documentation * (feature) Add user creation and login (#44) * Add tests for user * Align user schema for passport * Add delete user functionality * Add documentation * Align response with other response formats * (feature) Remove API from readme (#45) * (feature) Implement get bill, enable authentication on routes (Closes #11) (#47) * Create spec for bill controller * Align schema with api docs, comment out join table * Implemement bill retrieval * Align spec with api docs * Turn off request logging during testing * Add test for deleting bills * Add tests for authentication and getting bills * Fix error that prevented users from generating a session * Clean up code * Add retrieving bills * Add delete bill functionality * Implement isEditable for DescriptionField * Implement isEditable for TaxField * Refactor DescriptionField to stateless function * Refactor TipField to stateless function * Implement isEditable for TipField * Add 'uneditable' tests for BillItem * Refactor BillItem to stateless function * Refactor Bill components to use interactionType Interaction types are: - new: Creating a new bill - edit: Editing an existing bill - claim: Claiming items on an existing bill * Change bill submit button based on interactionType * Refactor tests to remove unnecessary variables * Align code with style guide * Display 401 message to user on unauth access * (feat) Login and signup features mostly complete (#49) * Implement ability to delete billItems * Implement ability to change bill Item values * Create Login page and css file * Create route and home-link to login page * Create utils directory for helper functions * Complete login signup form with api calls * Update login api calls and variable names * Fix emailAddress change bug * Create Login page and css file * Create route and home-link to login page * Create utils directory for helper functions * Complete login signup form with api calls * Update login api calls and variable names * Add CORS and nodemon * Add CORS and nodemon * Create temporaty variable for development url * Merge stash * (feat) Build serverUrl based on NODE_ENV * Add signup link to homepage * (feature) Add API documentation (#43) * Add documentation * (feature) Add API documentation * (feature) Add user creation and login (#44) * Add tests for user * Align user schema for passport * Add delete user functionality * Add documentation * Align response with other response formats * (feature) Remove API from readme (#45) * Implement isEditable for DescriptionField * Implement isEditable for TaxField * Refactor DescriptionField to stateless function * Refactor TipField to stateless function * Implement isEditable for TipField * Add 'uneditable' tests for BillItem * Refactor BillItem to stateless function * Refactor Bill components to use interactionType Interaction types are: - new: Creating a new bill - edit: Editing an existing bill - claim: Claiming items on an existing bill * Change bill submit button based on interactionType * Refactor tests to remove unnecessary variables * Align code with style guide * (feature) Implement get bill, enable authentication on routes (Closes #11) (#47) * Create spec for bill controller * Align schema with api docs, comment out join table * Implemement bill retrieval * Align spec with api docs * Turn off request logging during testing * Add test for deleting bills * Add tests for authentication and getting bills * Fix error that prevented users from generating a session * Clean up code * Add retrieving bills * Add delete bill functionality * Display 401 message to user on unauth access * Separate login and signup pages * Implement tests for login and signup * Link Signup component * Add css file for signup page * Add JSdocs syntax to describe functions * Fix merge conflict * Resolve merge conflicts * Remove rebase artifacts * Remove last merge conflict * (feature) Implement auth with JWT instead of sessions (#51) * Add profile page and update PUT field (#53) * Implement ability to delete billItems * Implement ability to change bill Item values * Create Login page and css file * Create route and home-link to login page * Create utils directory for helper functions * Complete login signup form with api calls * Update login api calls and variable names * Fix emailAddress change bug * Create Login page and css file * Create route and home-link to login page * Create utils directory for helper functions * Complete login signup form with api calls * Update login api calls and variable names * Add CORS and nodemon * Add CORS and nodemon * Create temporaty variable for development url * Merge stash * (feat) Build serverUrl based on NODE_ENV * Add signup link to homepage * (feature) Add API documentation (#43) * Add documentation * (feature) Add API documentation * (feature) Add user creation and login (#44) * Add tests for user * Align user schema for passport * Add delete user functionality * Add documentation * Align response with other response formats * (feature) Remove API from readme (#45) * Implement isEditable for DescriptionField * Implement isEditable for TaxField * Refactor DescriptionField to stateless function * Refactor TipField to stateless function * Implement isEditable for TipField * Add 'uneditable' tests for BillItem * Refactor BillItem to stateless function * Refactor Bill components to use interactionType Interaction types are: - new: Creating a new bill - edit: Editing an existing bill - claim: Claiming items on an existing bill * Change bill submit button based on interactionType * Refactor tests to remove unnecessary variables * Align code with style guide * (feature) Implement get bill, enable authentication on routes (Closes #11) (#47) * Create spec for bill controller * Align schema with api docs, comment out join table * Implemement bill retrieval * Align spec with api docs * Turn off request logging during testing * Add test for deleting bills * Add tests for authentication and getting bills * Fix error that prevented users from generating a session * Clean up code * Add retrieving bills * Add delete bill functionality * Display 401 message to user on unauth access * Separate login and signup pages * Implement tests for login and signup * Link Signup component * Add css file for signup page * Add JSdocs syntax to describe functions * Fix merge conflict * Resolve merge conflicts * Remove rebase artifacts * Implement user profile with POST for updating info * Complete profile update page * (documentation) Add auto generation of js docs (#56) * Add jsdoc auto generation * Fix errors in docs * Add trailing new line * (feature) Implement updating users via PUT /auth/user/:id (#52) * (feature) Change static file folder (#55) * (feature) Add getting user's bills, updating items, test refactor (#58) * Doc out item update * Implement database side of item updates * Remove unneeded require * Update spec to use shared helpers * Move dependencies from dev to make linter happy * Modify delete user to reference id not email * Add default value to item:paid * Modify finding items * Implement updateItem * Refine docs * Spec updating items * Implement retrieving all of a user's bills * Add public/index.html for localdev * Integrate JWT into Sign Up * Integrate JWT in Log In * Integrate JWT with Profile * Fix requestHandler for login * Refactor firstname/lastname to name to match API * Imtegrate JWT in bill creation * Integrate Bill update with JWT There is no appropriate API Route for updating a Bill. There _is_ a route for updating Bill items, but that doesn't help much to update the Bill's Tax/Tip/Description. * (feat) claim and pay for bill items * (feat) Paypal and SquareCash payment links * Remove unnecessary module * Add Travis CI integration (#62) * Add public/index.html for localdev * Integrate JWT into Sign Up * Integrate JWT in Log In * Integrate JWT with Profile * Fix requestHandler for login * Refactor firstname/lastname to name to match API * Imtegrate JWT in bill creation * Integrate Bill update with JWT There is no appropriate API Route for updating a Bill. There _is_ a route for updating Bill items, but that doesn't help much to update the Bill's Tax/Tip/Description. * (feat) claim and pay for bill items * (feat) Paypal and SquareCash payment links * Remove unnecessary module * Modify input fields to be consistent with API (#66) * (feat) JWT client integration (#63) * Add public/index.html for localdev * Integrate JWT into Sign Up * Integrate JWT in Log In * Integrate JWT with Profile * Fix requestHandler for login * Refactor firstname/lastname to name to match API * Imtegrate JWT in bill creation * Integrate Bill update with JWT There is no appropriate API Route for updating a Bill. There _is_ a route for updating Bill items, but that doesn't help much to update the Bill's Tax/Tip/Description. * (feat) claim and pay for bill items * (feat) Paypal and SquareCash payment links * Remove unnecessary module * Mock out bill update * (test) Improve tests for Login, Signup, Profile * (test) Improve tests for Bill* * (feature) Add server-side bill updating (#76) * Mock out bill update * Implement update bill * Update docs * (doc) Document dev and doc processes in README * (doc) Add brief introduction to Piddle in README Resolves #67 * (cleanup) ESLint cleanup * Add documentation (#80) * Modify input fields to be consistent with API * Implement css styles * Update configto use JWT_SECRET env var (#81) * Capitalize headers * Css homepage (#84) * Implement css styles * Implement home css styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back end portion of (#10) (#11)