(refactor) Style guide updates

server/db.js

@@ -1,6 +1,7 @@
 const config = require('../config.js');
 const Sequelize = require('sequelize');
 const Hashids = require('hashids');
+
 const hashIds = new Hashids('manatee salt', 5);
 
 console.log('db path:', config.db.path);
@@ -26,13 +27,12 @@ const Bill = sequelize.define('bill', {
     type: Sequelize.DECIMAL(10, 2), // eslint-disable-line
   },
 },
-{
-  hooks: {
-    afterCreate: (bill, options) => {
-      return bill.update({shortId: hashIds.encode(bill.dataValues.id)}); 
+  {
+    hooks: {
+      afterCreate: bill => bill.update({ shortId: hashIds.encode(bill.dataValues.id) }),
     },
   },
-});
+);
 
 const Item = sequelize.define('item', {
   description: {
@@ -79,7 +79,7 @@ User.belongsToMany(Bill, {
   foreignKey: 'debtorId',
 });
 
-Bill.belongsToMany(User, {through: BillDebtors});
+Bill.belongsToMany(User, { through: BillDebtors });
 
 Bill.belongsTo(User, {
   as: 'Payer',

server/dbControllers/billController.js

@@ -2,8 +2,7 @@ const Bill = require('../db').models.Bill;
 
 const itemController = require('./itemController');
 
-const createBill = bill => {
-
+const createBill = (bill) => {
   return new Promise((resolve, reject) => {
     if (!bill.payer) {
       return reject(new Error('Bill payer id required'));
@@ -12,18 +11,18 @@ const createBill = bill => {
       return reject(new Error('At least one bill item is required'));
     }
     // Need to find user and validate
-    Bill.create(bill)
-    .then(billRecord => {
+    return Bill.create(bill)
+    .then((billRecord) => {
       // have bill, now create the items
       itemController.createItemsForBill(billRecord.dataValues.id, bill.items)
-      .then(items => {
+      .then(() => {
         resolve(billRecord);
       })
-      .catch(err => {
+      .catch((err) => {
         reject(err);
       });
     })
-    .catch(err => {
+    .catch((err) => {
       reject(err);
     });
   });

server/dbControllers/itemController.js

@@ -7,11 +7,10 @@ const createItemsForBill = (billId, items) => {
 
   const itemsPromises = [];
 
-  items.forEach(item => {
-    itemsPromises.push(Item.create(Object.assign(item, {billId})));
+  items.forEach((item) => {
+    itemsPromises.push(Item.create(Object.assign(item, { billId })));
   });
   return Promise.all(itemsPromises);
-
 };
 
 module.exports = {

server/handlers/apiHandler.js

@@ -3,22 +3,23 @@ const billController = require('../dbControllers/billController');
 const saveBill = (request, response) => {
   const bill = request.body;
   billController.createBill(bill)
-    .then(bill => {
+    .then((billRecord) => {
       response.status(201);
       response.json({
         data: {
-          shortId: bill.shortId,
+          shortId: billRecord.shortId,
         },
       });
     })
-    .catch(error => {
+    .catch((error) => {
       response.status(400);
       response.json({
         error: {
           message: error.message,
         },
       });
     });
+};
 
 };
 

server/routes/auth.js

@@ -0,0 +1,9 @@
+const express = require('express');
+
+const router = express.Router(); // eslint-disable-line
+
+
+router.get('/', /* funct to handle bill*/);
+router.post('/', /* funct to create bill */);
+
+module.exports = router;

server/spec/dbControllersSpec.js

@@ -13,36 +13,36 @@ if (/test/.test(config.db.path) === false) {
 }
 
 describe('Item controller', () => {
-  before(done => {
+  before((done) => {
     Promise.all([
-      db.models.Item.sync()
+      db.models.Item.sync(),
     ])
     .then(() => {
       done();
     });
   });
 
-  it('should create items', done => {
+  it('should create items', (done) => {
     const items = [
-      {description: 'Grandma\'s curry', price: 10.99},
-      {description: 'Dr. Pepper', price: 1.99}
+      { description: 'Grandma\'s curry', price: 10.99 },
+      { description: 'Dr. Pepper', price: 1.99 },
     ];
     const billId = 21;
     itemController.createItemsForBill(21, items)
-    .then(itemsRecords => {
+    .then((itemsRecords) => {
       expect(itemsRecords.length).to.equal(2);
       expect(itemsRecords[0].dataValues.description).to.equal(items[0].description);
       expect(itemsRecords[1].dataValues.billId).to.equal(billId);
       done();
     })
-    .catch(err => {
+    .catch(() => {
       done();
     });
   });
 });
 
 describe('Bill controller', () => {
-  before(done => {
+  before((done) => {
     Promise.all([
       db.models.Item.sync(),
       db.models.Bill.sync(),
@@ -52,7 +52,7 @@ describe('Bill controller', () => {
     });
   });
 
-  it('should create bills', done => {
+  it('should create bills', (done) => {
     const bill = {
       description: 'Tu Lan lunch',
       tax: 2.46,
@@ -65,14 +65,13 @@ describe('Bill controller', () => {
       ],
     };
     billController.createBill(bill)
-      .then(billRecord => {
+      .then((billRecord) => {
         expect(billRecord.dataValues.description).to.equal(bill.description);
         expect(billRecord.dataValues.shortId).to.match(/\w{5,}/);
         done();
       })
-      .catch(err => {
+      .catch(() => {
         done();
       });
   });
-
 });