Skip to content

Commit

Permalink
Chore (VisBuilder): Update icon to use OUI icon (opensearch-project#4446
Browse files Browse the repository at this point in the history
) (opensearch-project#4463)

* Chore (VisBuilder): Update icon to use OUI icon

Fixes opensearch-project#3691

Signed-off-by: Josh Romero <[email protected]>

* update changelog

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Josh Romero <[email protected]>
(cherry picked from commit 4a778a7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <[email protected]>
  • Loading branch information
3 people authored Jul 5, 2023
1 parent 0331696 commit 401e383
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 56 deletions.
25 changes: 0 additions & 25 deletions src/plugins/vis_builder/public/assets/vis_builder_icon.svg

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import {
VisBuilderOutput,
VISBUILDER_EMBEDDABLE,
} from './vis_builder_embeddable';
import visBuilderIcon from '../assets/vis_builder_icon.svg';
import { getStateFromSavedObject } from '../saved_visualizations/transforms';
import {
getHttp,
Expand Down Expand Up @@ -55,7 +54,7 @@ export class VisBuilderEmbeddableFactory
name: PLUGIN_NAME,
includeFields: ['visualizationState'],
type: VISBUILDER_SAVED_OBJECT,
getIconForSavedObject: () => visBuilderIcon,
getIconForSavedObject: () => 'visBuilder',
};

// TODO: Would it be better to explicitly declare start service dependencies?
Expand Down
6 changes: 2 additions & 4 deletions src/plugins/vis_builder/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ import {
VisBuilderStart,
} from './types';
import { VisBuilderEmbeddableFactory, VISBUILDER_EMBEDDABLE } from './embeddable';
import visBuilderIconSecondaryFill from './assets/vis_builder_icon_secondary_fill.svg';
import visBuilderIcon from './assets/vis_builder_icon.svg';
import {
EDIT_PATH,
PLUGIN_ID,
Expand Down Expand Up @@ -189,7 +187,7 @@ export class VisBuilderPlugin
description: i18n.translate('visBuilder.visPicker.description', {
defaultMessage: 'Create visualizations using the new VisBuilder',
}),
icon: visBuilderIconSecondaryFill,
icon: 'visBuilder',
stage: 'experimental',
aliasApp: PLUGIN_ID,
aliasPath: '#/',
Expand All @@ -200,7 +198,7 @@ export class VisBuilderPlugin
description: attributes?.description,
editApp: PLUGIN_ID,
editUrl: `${EDIT_PATH}/${encodeURIComponent(id)}`,
icon: visBuilderIcon,
icon: 'visBuilder',
id,
savedObjectType: VISBUILDER_SAVED_OBJECT,
stage: 'experimental',
Expand Down

0 comments on commit 401e383

Please sign in to comment.