allow exporting number of RPC calls per method #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InoMurko
force-pushed
the
inomurko/adapter_measurements
branch
from
00abf16 to
cd7be67
Compare
ayrat555
reviewed
Feb 28, 2020
|
|
||
| ```elixir | ||
| config :ethereumex, | ||
| adapter: Datadog |
There was a problem hiding this comment.
Can you please add an example of the adapter in README?
the first argument is the key
Also, can you please clarify it? It looks like the first argument is the method name, right?
There was a problem hiding this comment.
added some text, pls check if it's better.... was struggling a bit :D
ayrat555
requested changes
Feb 28, 2020
InoMurko
force-pushed
the
inomurko/adapter_measurements
branch
from
77915bd to
b5bce49
Compare
ayrat555
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this to set the adapter to Datadog and that allows us to measure and plot the number of RPC calls we make.