-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmake option to compile library in shared or static #358
Add cmake option to compile library in shared or static #358
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 88 88
Lines 6622 6622
=======================================
Hits 5938 5938
Misses 684 684
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the static library and dynamic library on Windows should be different, otherwise it is impossible to build both of them at the same time.
EDIT: if this is urgent for the conan recipe, this can be done in a future PR, no need to block this one. There won't be any issue on Windows since the stati and dynamic builds are exclusive.
message(STATUS "🔧 Build static library") | ||
set(SPARROW_LIBRARY_TYPE STATIC) | ||
list(APPEND SPARROW_COMPILE_DEFINITIONS SPARROW_STATIC_LIB) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why making the static and dynamic builds exclusive?
I think that |
No description provided.