Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved inline implementation to src files #354

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

JohanMabille
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 78.26087% with 55 lines in your changes missing coverage. Please review.

Project coverage is 89.67%. Comparing base (ad38206) to head (a0f87e0).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/layout/null_array.cpp 73.07% 21 Missing ⚠️
src/layout/struct_layout/struct_array.cpp 77.21% 18 Missing ⚠️
include/sparrow/layout/union_array.hpp 33.33% 4 Missing ⚠️
src/layout/list_layout/list_value.cpp 0.00% 4 Missing ⚠️
...t/run_end_encoded_layout/run_end_encoded_array.cpp 69.23% 4 Missing ⚠️
src/layout/struct_layout/struct_value.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   90.13%   89.67%   -0.47%     
==========================================
  Files          85       88       +3     
  Lines        6579     6622      +43     
==========================================
+ Hits         5930     5938       +8     
- Misses        649      684      +35     
Flag Coverage Δ
unittests 89.67% <78.26%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohanMabille JohanMabille merged commit bf3a430 into man-group:main Feb 13, 2025
69 of 71 checks passed
@JohanMabille JohanMabille deleted the abi_pass1 branch February 13, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants