-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sparrow::nullable implementation #135
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
5a8d37b
sparrow::optional implementation
JohanMabille bf7282c
Update test/test_optional.cpp
JohanMabille 419d08b
Update test/test_optional.cpp
JohanMabille 7f7476f
Update test/test_optional.cpp
JohanMabille 8050eb2
Update test/test_optional.cpp
JohanMabille 94554d3
Update test/test_optional.cpp
JohanMabille 8954026
Update test/test_optional.cpp
JohanMabille a5751a0
Update test/test_optional.cpp
JohanMabille 49d609a
Update test/test_optional.cpp
JohanMabille 97c6451
Update test/test_optional.cpp
JohanMabille e0a2856
Update test/test_optional.cpp
JohanMabille 6e5bf3a
Update test/test_optional.cpp
JohanMabille 61510c0
Update test/test_optional.cpp
JohanMabille 3f82a7f
Update test/test_optional.cpp
JohanMabille 1413158
Update test/test_optional.cpp
JohanMabille ed3e873
Update test/test_optional.cpp
JohanMabille 87a4055
Update test/test_optional.cpp
JohanMabille 5851c8d
Update test/test_optional.cpp
JohanMabille 3a0f607
Update test/test_optional.cpp
JohanMabille be08491
Update test/test_optional.cpp
JohanMabille a86165f
Added make_optional helper
JohanMabille 9734b97
Added constraint on optional flag type parameter
JohanMabille 60df3a5
optional -> nullable
JohanMabille d849115
Fixed renaming
JohanMabille ac74c31
Changes according to review
JohanMabille dff865e
Simplified is_nullable_v implmeentation
JohanMabille 03e1ecf
Initialize from value / has_value overload to avoid accidental move o…
JohanMabille 0ad6267
Minor improvements
JohanMabille adf85c2
Changes according to review
JohanMabille 4f2e1cc
Added more documentation
JohanMabille 0c64d3c
GNiiiiiiaaaaaarrrrrgh
JohanMabille 3830cbc
Conditional noexcept
JohanMabille 760c3ff
Please merge me! I caaaan't wait!
JohanMabille fcf0fe2
Do not import boolean_like concept in sparrow namespace
JohanMabille File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add unit tests ?