build: Use C++20 and dynamically link the C++ standard library #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
build/dynamically-link-cpp-std
branch
from
ff72989 to
cdc6b1f
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
Signed-off-by: Julien Jerphanion <[email protected]>
|
Have you tried switching back to C++20 with these changes and seeing if the issue with Ray is definitely fixed? |
Signed-off-by: Julien Jerphanion <[email protected]>
|
I did, and I can confirm that it resolved the problem on my machine, but I think we should test those new wheels on more systems. |
jjerphan
changed the title
Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Johan Mabille <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
This was referenced May 17, 2024
JohanMabille
approved these changes
May 20, 2024
5 tasks
willdealtry
approved these changes
Jun 3, 2024
grusev
pushed a commit
that referenced
this pull request
Nov 25, 2024
Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Johan Mabille <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Mitigation for ray-project/ray#18506 (comment).
What does this implement or fix?
manylinuxwheels (startingmanylinux1) must depend on external libraries, including the C++ standard library.Currently, it does, and this might be the cause of problems at runtime with standard librairies shared objects being loaded with duplication as observed with importing ray and ArcticDB.
This PR makes ArcticDB depend on implementations of the standard library dynamically rather than statically.
This removes the
STATIC_LINK_STD_LIBoption, which is thus not needed anymore.Any other comments?
A few patches are necessary to have ArcticDB compile without using the Docker Image.
Once this is merged, we should be able to reintroduce C++20.