-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unified should output multi-word, dash-delimited descriptors with appropriate case #10
Comments
good catch, @corntoole. |
I assume this is "best/oreferred practice" for proto files, right? any chance you can scaratch out some simple "rules" (e.g. when to use i'd be happy to code up the rules into the tool. thx. |
Yes, the suggested naming convention for protocol buffers is for message names to be camel-case, e.g. I haven't yet found an official style guide for graphQL, but it seems that types names should be capitalized-camel-case and all other identifiers camel-case. |
very good. thanks for the great proto styleguide reference![1] so, for if/when you find a solid style guide for SDL/GraphQL or OpenAPI feel free to start a new issue for them, too. #thanks. [1] https://developers.google.com/protocol-buffers/docs/style#message_and_field_names |
added a branch w/ your suggested changes: can you check this out and add remarks? if all is good, i'll do the merge when you're ready. |
sorry for the radio silence. i got stumped as i was working to incorporate some of the work of @mmuller88 and his WSD CDK project. i'll circle back and see where we can pick up on this in the next week or so. hope to see you on the mailing list and at one of our ALPS Open Office Hours sometime soon, too. -- @mamund |
When unified is given descriptors with multi-word, dash-delimited identifiers e.g.
date-time
, it outputs types and RPCs with invalid names in SDL and ProtocolBuffer syntax.Example 1
Descriptors for state transitions should use camel-case; data descriptors should use camel-case or snake-case as appropriate.
Here is the full ALPS yaml that I'm testing. I converted it from alps-io/profiles/xml/microblogging.xml
The text was updated successfully, but these errors were encountered: