Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mid Devon, UK #3596

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add Mid Devon, UK #3596

wants to merge 1 commit into from

Conversation

edwade3
Copy link

@edwade3 edwade3 commented Jan 15, 2025

1st Attempt at Mid Devon

When I try to run the tests though I get the following:

Testing source mid_devon_gov_uk ...
  Cullompton failed: list indices must be integers or slices, not str
  Cullompton - string failed: list indices must be integers or slices, not str

Any help appreciated

@edwade3 edwade3 mentioned this pull request Jan 15, 2025
Open
mathiassmichno
mathiassmichno reviewed Jan 16, 2025
View reviewed changes
...om_components/waste_collection_schedule/waste_collection_schedule/source/mid_devon_gov_uk.py
API_URLS["authResp"] + "&_" + urlNonce + "&sid=" + sessionKey,
headers=HEADERS,
)
authenticateResponseNonce = self.achieveFormsData(authRespRequest)["0"][
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your comment with tests failing to run, I guess the ["0"] should be [0]

mathiassmichno
mathiassmichno reviewed Jan 16, 2025
View reviewed changes
Copy link

@mathiassmichno mathiassmichno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run test_sources.py with -t to get traceback for the error you are seeing

@5ila5 5ila5 marked this pull request as draft January 17, 2025 16:18
@5ila5
Copy link
Collaborator

5ila5 commented Jan 17, 2025

Even when changing this, I still get errors. Please ping me again when the tests run successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiassmichno mathiassmichno mathiassmichno left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwade3 @5ila5 @mathiassmichno