Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: London Borough of Merton #3317

Merged
merged 6 commits into from
Dec 29, 2024
Merged

Update: London Borough of Merton #3317

merged 6 commits into from
Dec 29, 2024

Conversation

dt215git
Copy link
Contributor

Website appears to have changed to new endpoint, and now offers calendars compatible with the ics source.
Yaml added describing configuration. Entry in README has (New) suffix. Fixes #3226

Old end point still seems to be active, so have updated that .py to cope with properties that have garden waste descriptions. This should keep legacy HA instances functional while the old endpoint remains active. This also addresses the failing test cases mentioned in #2876. Entry in README now has (Old) suffix.

Testing source merton_gov_uk ...
  found 6 entries for Without Garden Waste
    2025-01-03 : Food waste [mdi:food]
    2025-01-09 : Paper and card [mdi:newspaper]
    2025-01-03 : Plastics, glass, cans and cartons [mdi:glass-fragile]
    2025-01-09 : Rubbish [mdi:trash-can]
    2025-01-03 : Textiles [mdi:hanger]
    2025-01-03 : Household batteries [mdi:battery]
  found 7 entries for With Garden Waste
    2024-12-31 : Food waste [mdi:food]
    2024-12-31 : Paper and card [mdi:newspaper]
    2025-01-07 : Plastics, glass, cans and cartons [mdi:glass-fragile]
    2024-12-31 : Rubbish [mdi:trash-can]
    2024-12-31 : Textiles [mdi:hanger]
    2024-12-31 : Household batteries [mdi:battery]
    2025-01-07 : Garden waste [mdi:leaf]

@5ila5 5ila5 merged commit 06699b5 into mampfes:master Dec 29, 2024
2 checks passed
@5ila5
Copy link
Collaborator

5ila5 commented Dec 29, 2024 •
edited
Loading

Thanks for your contribution

@5ila5 5ila5 mentioned this pull request Dec 29, 2024
Closed
7 tasks
@dt215git dt215git mentioned this pull request Dec 30, 2024
Closed
7 tasks
@dt215git dt215git deleted the update_merton branch December 30, 2024 07:40
5ila5 pushed a commit to MrNunu/hacs_waste_collection_schedule that referenced this pull request Dec 30, 2024
@dt215git @5ila5
Update: London Borough of Merton (mampfes#3317)
2cd95a4 
* reworked to add garden waste test case

* merton yaml added

* update_docu_links

* Update names for README

* update test case names

* yaml instructions updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5ila5 5ila5 5ila5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: London Borough of Merton format changed
2 participants
@dt215git @5ila5