Rewrite component storage #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Him188
added
s:console
Him188
force-pushed
the
rewrite-compoennt-storage
branch
from
327d6b7 to
3d888e1
Compare
Karlatemp
reviewed
Feb 19, 2022
Him188
added
x:deprecation
… `priority`. Remove `builtinImplementations` and contribute them at the first initialization phase instead. Close #1888, fix #1860. Add `ComponentStorageInternal` for frontend to provide components. Deprecate: - SingletonExtension - SingletonExtensionPoint - AbstractSingletonExtensionPoint - SingletonExtensionSelector - CommandCallInterceptorProviderImpl - CommandCallInterceptorProviderImplLazy - CommandCallParserProviderImpl - CommandCallParserProviderImplLazy - CommandCallResolverProviderImpl - CommandCallResolverProviderImplLazy ABI breaking change: - `PermissionServiceProvider`: supertype changed - `CommandCallResolverProvider.ExtensionPoint`: supertype changed - `PermissionServiceProvider.ExtensionPoint`: supertype changed
Him188
force-pushed
the
rewrite-compoennt-storage
branch
from
3d888e1 to
defdf30
Compare
…ve then in DataScope, instead of making them objects.
Him188
force-pushed
the
rewrite-compoennt-storage
branch
from
defdf30 to
1ada8d5
Compare
|
确实, 添加了一个 commit, force 是为了 rebase onto dev |
Karlatemp
approved these changes
Feb 24, 2022
This was
linked to
issues
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for changes