Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

撤销 '阻止用户发送 FileMessage' (#1646) 的修改, 改为日志警告, 并在未来版本再恢复禁止 #1715

Closed
Him188 opened this issue Dec 6, 2021 · 1 comment · Fixed by #1716
Closed

撤销 '阻止用户发送 FileMessage' (#1646) 的修改, 改为日志警告, 并在未来版本再恢复禁止 #1715

Him188 opened this issue Dec 6, 2021 · 1 comment · Fixed by #1716
Labels
M 优先级: 主要 s:core 子系统: mirai-core t:problem 类型: 不容易归类为特性或 bug 的综合问题 x:behavior-change 属性: 行为变更 (API 不变, 行为改变)
Milestone
2.10.0-RC

Comments

@Him188
Copy link
Member

Him188 commented Dec 6, 2021 •
edited
Loading

2.8.0 禁止发送导致旧代码直接失败, 尤其是各语言 SDK 如 MAH.

相关问题:

计划解决方案:

  • 2.8.3: 撤销禁止, 改为在发送 FileMessage 时在日志警告
  • 2.10: 恢复禁止, 但也仍然要允许通过 RemoteFile.upload 创建的 FileMessage 的上传
@Him188 Him188 added this to 2.10.0-RC and 2.8.3 Dec 6, 2021
@Him188 Him188 modified the milestone: 2.10 Dec 6, 2021
@Him188 Him188 added C 优先级: 最高 M 优先级: 主要 t:problem 类型: 不容易归类为特性或 bug 的综合问题 and removed C 优先级: 最高 labels Dec 6, 2021
@Him188 Him188 changed the title 撤销 '阻止用户发送 FileMessage' (#1646) 的修改, 改为 warning, 并在未来版本再删除 撤销 '阻止用户发送 FileMessage' (#1646) 的修改, 改为日志警告, 并在未来版本再删除 Dec 6, 2021
@Him188 Him188 changed the title 撤销 '阻止用户发送 FileMessage' (#1646) 的修改, 改为日志警告, 并在未来版本再删除 撤销 '阻止用户发送 FileMessage' (#1646) 的修改, 改为日志警告, 并在未来版本再恢复禁止 Dec 6, 2021
@Him188 Him188 moved this to In Progress in 2.8.3 Dec 6, 2021
@Him188 Him188 moved this to Todo in 2.10.0-RC Dec 6, 2021
Him188 added a commit that referenced this issue Dec 6, 2021
@Him188
Revert prohibition of sending file message:
dca732e 
- close #1715
- Report a warning in logging with stacktrace
- Show stacktrace only once
@Him188 Him188 mentioned this issue Dec 6, 2021
Merged
@Him188 Him188 added this to 2.9.0-RC Dec 6, 2021
@Him188 Him188 moved this to In Progress in 2.9.0-RC Dec 6, 2021
Him188 added a commit that referenced this issue Dec 6, 2021
@Him188
Revert prohibition of sending file message: (#1716)
2367ee0 
* Revert prohibition of sending file message:
- close #1715
- Report a warning in logging with stacktrace
- Show stacktrace only once

* Update util.kt
Repository owner moved this from Todo to Done in 2.10.0-RC Dec 6, 2021
Repository owner moved this from In Progress to Fixed in 2.9.0-RC Dec 6, 2021
Repository owner moved this from In Progress to Fixed in 2.8.3 Dec 6, 2021
@Him188 Him188 moved this from Done to In Progress in 2.10.0-RC Dec 9, 2021
@Him188 Him188 reopened this Dec 9, 2021
@Him188 Him188 moved this from In Progress to Todo in 2.10.0-RC Dec 9, 2021
@Him188 Him188 modified the milestones: 2.10, 2.8.3, 2.10.0-RC Dec 10, 2021
Him188 added a commit that referenced this issue Dec 11, 2021
@Him188
Revert prohibition of sending file message: (#1716)
fb46beb 
* Revert prohibition of sending file message:
- close #1715
- Report a warning in logging with stacktrace
- Show stacktrace only once

* Update util.kt
@Him188 Him188 added the s:core 子系统: mirai-core label Jan 4, 2022
@Him188 Him188 added the x:behavior-change 属性: 行为变更 (API 不变, 行为改变) label Jan 14, 2022
@Him188 Him188 closed this as completed in 1299935 Jan 14, 2022
Repository owner moved this from Todo to Done in 2.10.0-RC Jan 14, 2022
@Him188
Copy link
Member Author

Him188 commented Feb 6, 2022

备注：可以用 -Dmirai.message.allow.sending.file.message=true 去除任何关于发送 FileMessage 的限制

inshinno pushed a commit to inshinno/mirai that referenced this issue Feb 21, 2022
@Him188 @inshinno
Prohibit sending FileMessage manually, except those from `FileMessa…
4ab8072 
…ge.upload`. close mamoe#1715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
M 优先级: 主要 s:core 子系统: mirai-core t:problem 类型: 不容易归类为特性或 bug 的综合问题 x:behavior-change 属性: 行为变更 (API 不变, 行为改变)
Projects
2.10.0-RC
Status: Done
2.8.3
Status: Fixed
2.9.0-RC
Status: Fixed
Milestone
2.10.0-RC
Development

Successfully merging a pull request may close this issue.

Revert prohibition of sending file message: mamoe/mirai
1 participant
@Him188