Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin micromamba default version to 1.* #232

Merged
merged 2 commits into from
Oct 3, 2024
Merged

pin micromamba default version to 1.* #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4b8e55
pin micromamba default version to 1.*
pavelzw Oct 3, 2024
ab73b58
fix tests
pavelzw Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./
with:
micromamba-version: 2.0.2-0
- run: |
micromamba info | grep -q "environment : base"
shell: bash -el {0}
Expand Down Expand Up @@ -168,6 +170,7 @@ jobs:
with:
environment-file: 'test/environment.yml'
condarc-file: 'test/.condarc'
micromamba-version: 2.0.2-0
- run: | # this should only work when the pytorch channel is loaded, i.e., the custom condarc is used
micromamba search pytorch=2.0.0
micromamba search pytorch=2.0.0 | grep -q "pytorch 2.0.0 py3.10_cpu_0"
Expand Down
70 changes: 70 additions & 0 deletions dist/licenses.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/main.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "setup-micromamba",
"version": "1.10.0",
"version": "1.11.0",
"private": true,
"description": "Action to setup micromamba",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ const inferOptions = (inputs: Inputs): Options => {
// if micromambaUrl is specified, use that, otherwise use micromambaVersion (or 'latest' if not specified)
const micromambaSource = inputs.micromambaUrl
? right(inputs.micromambaUrl)
: left(inputs.micromambaVersion || 'latest')
: left(inputs.micromambaVersion || '1.5.10-0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would require updating the GHA each time a 1.x is released, which I find fragile, but I don't have a better solution for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

every other solution would imply some weird api calls to get the latest v1 version which could also break


// we write to condarc if a condarc file is not already specified
const writeToCondarc = inputs.condarcFile === undefined
Expand Down
Loading