Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Remove another uninitialized variable in curl handler #3678

Merged
merged 1 commit into from
Dec 10, 2024
Merged

build: Remove another uninitialized variable in curl handler #3678

merged 1 commit into from
Dec 10, 2024

Conversation

dannf
Copy link
Contributor

@dannf dannf commented Dec 9, 2024 •
edited
Loading

Similar to commit 4c5c1d7. Compile-tested only.

@jjerphan jjerphan added the release::bug_fixes For PRs fixing bugs label Dec 10, 2024
@JohanMabille
Copy link
Member

JohanMabille commented Dec 10, 2024 •
edited
Loading

Did the compiler emit a warning about it? I find it weird to initialize a variable that will be garbaged after the function, and my local build did not catch it (with gcc14).

@jjerphan jjerphan changed the title Fix another uninitialized variable in curl handler build: Remove another uninitialized variable in curl handler Dec 10, 2024
@jjerphan jjerphan merged commit bb38a69 into mamba-org:main Dec 10, 2024
34 of 35 checks passed
@dannf
Copy link
Contributor Author

dannf commented Dec 10, 2024

Did the compiler emit a warning about it? I find it weird to initialize a variable that will be garbaged after the function, and my local build did not catch it (with gcc14).

Thanks for merging. And yes, it did, apologies for not explicitly mentioning that. Here's a log of the failed build, followed by a log of applying the fix and continuing the build. Perhaps something in the way we have our gcc-14 configured is giving us different behavior? Or perhaps it's the way I'm configuring the mamba build?

~/mamba $ git reset --hard bb38a69~1
HEAD is now at 693ee82c Fix compilation with -Werror=unused-result (#3676)
~/mamba $ git clean -x -f -d .
Removing CMakeCache.txt
Removing CMakeFiles/
Removing libmamba/CMakeFiles/
Removing libmamba/ext/solv-cpp/CMakeFiles/
Removing libmamba/shell_scripts/
~/mamba $ cmake -DBUILD_LIBMAMBA="ON" -DBUILD_SHARED="ON" -DBUILD_LIBMAMBAPY="OFF" -DBUILD_MICROMAMBA="OFF" -DBUILD_MAMBA_PACKAGE="OFF" -DCMAKE_
BUILD_TYPE=Release
CMake Warning:
  No source or binary directory provided.  Both will be assumed to be the
  same as the current working directory, but note that this warning will
  become a fatal error in future CMake releases.


-- The C compiler identification is GNU 14.2.0
-- The CXX compiler identification is GNU 14.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/local/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/local/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Building libmamba v2.0.5
-- libmamba binary version: v2.0.0
-- Found Python3: /usr/bin/python3.12 (found version "3.12.8") found components: Interpreter
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found nlohmann_json: /usr/share/cmake/nlohmann_json/nlohmann_jsonConfig.cmake (found version "3.11.3")
-- Found PkgConfig: /usr/bin/pkg-config (found version "2.3.0")
-- Found Libsolv: /usr/include (found version "0.7.31")
-- Setting LTO for target libmamba::solv-cpp
-- Adding shared libmamba target
-- Setting LTO for target libmamba::libmamba-dyn
   -> Dynamically linking against libmamba (shared) dependencies
-- Found CURL: /usr/lib/libcurl.so (found version "8.11.0")
-- Found LibArchive: /usr/lib/libarchive.so (found version "3.7.7")
-- Found BZip2: /usr/lib/libbz2.so (found version "1.0.8")
-- Looking for BZ2_bzCompressInit
-- Looking for BZ2_bzCompressInit - found
-- Found OpenSSL: /usr/lib/libcrypto.so (found version "3.4.0")
-- Configuring done (2.1s)
-- Generating done (0.0s)
-- Build files have been written to: /home/build/mamba
~/mamba $ cmake --build . --parallel
[  1%] Building CXX object libmamba/ext/solv-cpp/CMakeFiles/solv-cpp.dir/src/pool.cpp.o
[  2%] Building CXX object libmamba/ext/solv-cpp/CMakeFiles/solv-cpp.dir/src/solvable.cpp.o
[  4%] Building CXX object libmamba/ext/solv-cpp/CMakeFiles/solv-cpp.dir/src/queue.cpp.o
[  4%] Building CXX object libmamba/ext/solv-cpp/CMakeFiles/solv-cpp.dir/src/solver.cpp.o
[  4%] Building CXX object libmamba/ext/solv-cpp/CMakeFiles/solv-cpp.dir/src/repo.cpp.o
[  5%] Building CXX object libmamba/ext/solv-cpp/CMakeFiles/solv-cpp.dir/src/transaction.cpp.o
[  5%] Built target solv-cpp
[  6%] Generating shell_scripts/mamba_hook.ps1.cpp
[  6%] Generating shell_scripts/activate.bat.cpp
[  8%] Generating shell_scripts/_mamba_activate.bat.cpp
[  8%] Generating shell_scripts/compile_pyc.py.cpp
[  8%] Generating shell_scripts/Mamba.psm1.cpp
[  9%] Generating shell_scripts/mamba.bat.cpp
[ 10%] Generating shell_scripts/mamba.csh.cpp
[ 10%] Generating shell_scripts/mamba.sh.cpp
[ 11%] Generating shell_scripts/mamba.fish.cpp
[ 12%] Generating shell_scripts/mamba.xsh.cpp
[ 12%] Generating shell_scripts/mamba_completion.posix.cpp
[ 13%] Generating shell_scripts/mamba_hook.bat.cpp
[ 14%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/version.cpp.o
[ 16%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/os_unix.cpp.o
[ 16%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/encoding.cpp.o
[ 17%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/cfile.cpp.o
[ 17%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/cryptography.cpp.o
[ 18%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/fs/filesystem.cpp.o
[ 20%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/os_linux.cpp.o
[ 20%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/parsers.cpp.o
[ 21%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/environment.cpp.o
[ 22%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/os_win.cpp.o
[ 23%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/url_manip.cpp.o
[ 23%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/os_osx.cpp.o
[ 23%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/path_manip.cpp.o
[ 24%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/random.cpp.o
[ 25%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/string.cpp.o
[ 25%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/util/url.cpp.o
[ 26%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/archive.cpp.o
[ 27%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/authentication_info.cpp.o
[ 28%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/build_number_spec.cpp.o
[ 28%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/channel.cpp.o
[ 29%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/chimera_string_spec.cpp.o
[ 30%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/glob_spec.cpp.o
[ 31%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/match_spec.cpp.o
[ 31%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/conda_url.cpp.o
[ 32%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/package_info.cpp.o
[ 33%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/platform.cpp.o
[ 34%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/regex_spec.cpp.o
[ 34%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/repo_data.cpp.o
[ 36%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/version_spec.cpp.o
[ 36%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/unresolved_channel.cpp.o
[ 37%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/specs/version.cpp.o
[ 37%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/solver/helpers.cpp.o
[ 38%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/solver/problems_graph.cpp.o
[ 39%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/solver/libsolv/database.cpp.o
[ 40%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/solver/libsolv/helpers.cpp.o
[ 40%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/solver/libsolv/matcher.cpp.o
[ 41%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/solver/libsolv/parameters.cpp.o
[ 42%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/solver/libsolv/repo_info.cpp.o
[ 43%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/solver/libsolv/solver.cpp.o
[ 43%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/solver/libsolv/unsolvable.cpp.o
[ 44%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/validation/errors.cpp.o
[ 45%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/validation/keys.cpp.o
[ 45%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/validation/tools.cpp.o
[ 46%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/validation/repo_checker.cpp.o
[ 47%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/validation/update_framework_v0_6.cpp.o
[ 48%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/validation/update_framework_v1.cpp.o
[ 49%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/validation/update_framework.cpp.o
[ 49%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/download/compression.cpp.o
[ 50%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/download/curl.cpp.o
[ 51%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/download/downloader.cpp.o
[ 52%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/download/mirror_impl.cpp.o
[ 52%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/download/mirror_map.cpp.o
[ 53%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/download/mirror.cpp.o
[ 54%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/download/request.cpp.o
[ 55%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/activation.cpp.o
[ 55%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/channel_context.cpp.o
[ 56%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/context.cpp.o
[ 57%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/download_progress_bar.cpp.o
[ 57%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/env_lockfile.cpp.o
[ 58%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/environments_manager.cpp.o
[ 59%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/error_handling.cpp.o
[ 60%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/execution.cpp.o
[ 61%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/history.cpp.o
[ 61%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/fsutil.cpp.o
[ 62%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/link.cpp.o
[ 63%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/menuinst.cpp.o
[ 64%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/package_cache.cpp.o
[ 64%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/output.cpp.o
[ 65%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/package_database_loader.cpp.o
[ 66%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/package_fetcher.cpp.o
[ 66%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/package_handling.cpp.o
[ 67%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/package_paths.cpp.o
[ 68%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/pinning.cpp.o
[ 69%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/prefix_data.cpp.o
[ 69%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/progress_bar_impl.cpp.o
[ 70%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/progress_bar.cpp.o
[ 71%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/query.cpp.o
[ 72%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/repo_checker_store.cpp.o
[ 72%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/run.cpp.o
[ 73%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/shell_init.cpp.o
[ 74%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/singletons.cpp.o
[ 75%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/subdirdata.cpp.o
[ 75%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/thread_utils.cpp.o
[ 76%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/timeref.cpp.o
[ 77%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/transaction_context.cpp.o
[ 78%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/transaction.cpp.o
[ 78%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/util_os.cpp.o
[ 79%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/util.cpp.o
[ 80%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/core/virtual_packages.cpp.o
[ 81%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/c_api.cpp.o
[ 81%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/channel_loader.cpp.o
[ 82%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/clean.cpp.o
[ 83%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/config.cpp.o
[ 84%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/configuration.cpp.o
[ 84%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/create.cpp.o
[ 85%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/info.cpp.o
[ 86%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/install.cpp.o
[ 87%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/list.cpp.o
[ 88%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/remove.cpp.o
[ 88%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/utils.cpp.o
[ 89%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/repoquery.cpp.o
[ 90%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/shell.cpp.o
[ 90%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/api/update.cpp.o
[ 91%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/mamba.sh.cpp.o
[ 91%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/activate.bat.cpp.o
[ 93%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/mamba.csh.cpp.o
[ 93%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/mamba.bat.cpp.o
[ 94%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/_mamba_activate.bat.cpp.o
[ 95%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/mamba_hook.bat.cpp.o
[ 96%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/mamba_hook.ps1.cpp.o
[ 96%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/Mamba.psm1.cpp.o
[ 97%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/mamba.fish.cpp.o
[ 98%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/mamba.xsh.cpp.o
[ 99%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/compile_pyc.py.cpp.o
[ 99%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/shell_scripts/mamba_completion.posix.cpp.o
In file included from /usr/include/c++/14/bits/stl_function.h:60,
                 from /usr/include/c++/14/functional:49,
                 from /home/build/mamba/libmamba/src/download/curl.cpp:7:
In function 'std::_Require<std::__not_<std::__is_tuple_like<_Tp> >, std::is_move_constructible<_Tp>, std::is_move_assignable<_Tp> > std::swap(_Tp&, _Tp&) [with _Tp = char]',
    inlined from 'void std::iter_swap(_ForwardIterator1, _ForwardIterator2) [with _ForwardIterator1 = char*; _ForwardIterator2 = char*]' at /usr/include/c++/14/bits/stl_algobase.h:185:11,
    inlined from '_ForwardIterator2 std::swap_ranges(_ForwardIterator1, _ForwardIterator1, _ForwardIterator2) [with _ForwardIterator1 = char*; _ForwardIterator2 = char*]' at /usr/include/c++/14/bits/stl_algobase.h:215:16,
    inlined from 'void std::array<_Tp, _Nm>::swap(std::array<_Tp, _Nm>&) [with _Tp = char; long unsigned int _Nm = 256]' at /usr/include/c++/14/array:127:25,
    inlined from 'std::__enable_if_t<((bool)typename std::__array_traits<_Tp, _Nm>::_Is_swappable::value)> std::swap(array<_Tp, _Nm>&, array<_Tp, _Nm>&) [with _Tp = char; long unsigned int _Nm = 256]' at /usr/include/c++/14/array:379:17,
    inlined from 'mamba::download::CURLHandle::CURLHandle(mamba::download::CURLHandle&&)' at /home/build/mamba/libmamba/src/download/curl.cpp:253:18:
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[1]' may be used uninitialized [-Werror=maybe-uninitialized]
  221 |       _Tp __tmp = _GLIBCXX_MOVE(__a);
      |           ^~~~~
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[2]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[3]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[4]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[5]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[6]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[7]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[8]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[9]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[10]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[11]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[12]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[13]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[14]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[15]' may be used uninitialized [-Werror=maybe-uninitialized]
/usr/include/c++/14/bits/move.h:221:11: error: '((__vector(16) char*)this)[16]' may be used uninitialized [-Werror=maybe-uninitialized]
cc1plus: all warnings being treated as errors
make[2]: *** [libmamba/CMakeFiles/libmamba-dyn.dir/build.make:796: libmamba/CMakeFiles/libmamba-dyn.dir/src/download/curl.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:115: libmamba/CMakeFiles/libmamba-dyn.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

And now if I apply the fix and continue:

~/mamba $ git reset --hard bb38a69
HEAD is now at bb38a698 build: Remove another uninitialized variable in curl handler (#3678)
~/mamba $ cmake --build . --parallel
[  5%] Built target solv-cpp
[  6%] Building CXX object libmamba/CMakeFiles/libmamba-dyn.dir/src/download/curl.cpp.o
[  7%] Linking CXX shared library libmamba.so
[100%] Built target libmamba-dyn
~/mamba $

@JohanMabille
Copy link
Member

Thanks for the detailed log ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannf @JohanMabille @jjerphan