maint: Remove anonymous namespace in tests #3664
Conversation
| } | ||
|
|
||
| using namespace mamba::specs::match_spec_literals; | ||
| using Request = solver::Request; | ||
|
|
||
| namespace |
There was a problem hiding this comment.
I added this one because mpkg function is also present in another test file (and I added anon namespace there as well)
| } | ||
| } // namespace mamba |
There was a problem hiding this comment.
This comment seems to be wrong, I think it was 2 nested anonymous namespaces
|
Naive question: can you explain what is the plus-value of those changes whose diff is large an noisy? |
Well, not much, but it makes tests look more consistent (and a bit shorter). I told I would work on this when I was working on Catch2, so delivering my promise: #3618 (comment) |
|
In that case I would find it safer to replace anonymous namespaces with named namespaces instead of removing them. This could lead to duplicated symbols in the future because of tests with very gneric names (constructor, swap, etc). Keeping anonymous namespaces is fine too. |
|
I would also keep the anonymous namespace (and thus close this PR). We could name them, but I would not act unless we see a real benefit or unless it fixes problems. |
|
Ok, closing this PR |
No description provided.