Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle space in mamba and micromamba executable absolute paths #3525

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

NewUserHa
Copy link
Contributor

version: micromamba-2.0.2-0.tar.bz2

on windows cmd,
it will fail by 'C:\Program' is not recognized as an internal or external command, operable program or batch file. when micromamba.exe is located at eg C:\Program Files.

this PR fixed it.

@jjerphan jjerphan added the release::bug_fixes For PRs fixing bugs label Oct 14, 2024
@jjerphan jjerphan changed the title fix run mamba and micromamba error when the .exe path with space on windows fix: Handle space in mamba and micromamba executable absolute paths Oct 14, 2024
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The failure on the CI are unrelated and should be resolved by #3537.

Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjerphan jjerphan merged commit 9eb2401 into mamba-org:main Oct 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants