fix: Environment removal confirmation #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
force-pushed
the
fix-remove-all
branch
2 times, most recently
from
5c3c128 to
7d86a6a
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
fix-remove-all
branch
from
7d86a6a to
03d14d3
Compare
|
Can we add a test with the y/n answers and check removals? |
I'd like to, but I do not see how can one test the |
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
SylvainCorlay
approved these changes
Sep 17, 2024
Signed-off-by: Julien Jerphanion <[email protected]>
JohanMabille
approved these changes
Sep 17, 2024
Hind-M
reviewed
Sep 17, 2024
Co-authored-by: Hind-M <[email protected]>
|
The test failure with pip & Numpy appears with other unrelated PRs and is unrelated to this change. We are tracking this in a follow up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3437.